feat(SelectMenu): add clearable icon to reset modelValue #3244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gulbis/ui into feat/select-menu-clearable
|
hey @benjamincanac |
|
@benjamincanac Could you please give me some instructions to make this good to merge? |
|
up, i really need this feature 🚀 |
|
what are we waiting for |
|
Sorry for the delay on this, I've updated the PR and merged v3 but do note that this only works when the user actually provide a |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #1057
❓ Type of change
📚 Description
Added clear button to the
SelectMenu📝 Checklist